Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): add last operator and update marble tests to support grouping #307

Merged
merged 2 commits into from
Sep 14, 2015
Merged

feat(operator): add last operator and update marble tests to support grouping #307

merged 2 commits into from
Sep 14, 2015

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Sep 13, 2015

  • adds EmptyError error type
  • adds ability to group values in marble tests
  • adds last operator

closes #304
closes #306

@benlesh benlesh mentioned this pull request Sep 13, 2015
Closed
@benlesh benlesh changed the title feat(operator): add last operator feat(operator): add last operator and update marble tests to support grouping Sep 13, 2015
@benlesh
Copy link
Member Author

benlesh commented Sep 13, 2015

now the marble tests support grouping.. where the ( designates the frame a group is emitted on, and it gathers all of the values until it finds a ) ... nested groups are not supported.

merging this:

----a------|
----(bc)---|

makes this:

----(abc)--|

@benlesh
Copy link
Member Author

benlesh commented Sep 13, 2015

attn @kwonoj @staltz

kwonoj
kwonoj reviewed Sep 13, 2015
View reviewed changes
spec/operators/last-spec.js
describe('Observable.prototype.last()', function(){
it('should take the last value of an observable', function(){
var e1 = hot('--a--^--b--c--|');
var expected = '---------(c|)';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend to unclose parenthesis when completed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nexted value and a completion in the same frame

@benlesh
feat(operator): add last operator
d841b11 
- adds EmptyError error type
- adds ability to group values in marble tests
- adds last operator

closes #304
closes #306
@benlesh
chore(test): add micro perf for last operator
53191ed
@benlesh benlesh merged commit 53191ed into ReactiveX:master Sep 14, 2015
@benlesh benlesh deleted the last branch September 14, 2015 17:03
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add last operator Marble diagram tests just don't work for synchronous scenarios
2 participants
@benlesh @kwonoj