Typo/error in withLatestFrom() test?

[apaatsio]

There is a test called "should combine events from cold observables" but the test itself uses hot().

Link to the section in code: https://github.com/ReactiveX/rxjs/blob/master/spec/operators/withLatestFrom-spec.ts#L16-L24

Here's the test code:

  asDiagram('withLatestFrom')('should combine events from cold observables', () => {
    const e1 =   hot('-a--b-----c-d-e-|');
    const e2 =   hot('--1--2-3-4---|   ');
    const expected = '----B-----C-D-E-|';

    const result = e1.withLatestFrom(e2, (a: string, b: string) => String(a) + String(b));

    expectObservable(result).toBe(expected, { B: 'b1', C: 'c4', D: 'd4', E: 'e4' });
  });

[kwonoj]

uh..seems so? I can't recall which one's intended though (description vs. test) 😅

[kwonoj]

marking as 'bug', at least it's incorrect state.

[martinsik]

I think it should use cold() because hot Observables are tested right in the next test case: https://github.com/ReactiveX/rxjs/blob/master/spec/operators/withLatestFrom-spec.ts#L26

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.