Propagate outer abort signal 'reason' to internal abort call #7555
                  
                    
                      AndreasPresthammer
                    
                  
                
                  started this conversation in
                Ideas / Feature request
              
            Replies: 0 comments
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
        
    
Uh oh!
There was an error while loading. Please reload this page.
-
When
outerSignalis in aborted state hererxjs/packages/rxjs/src/internal/observable/dom/fetch.ts
Line 117 in c15b37f
.abort()on the internalAbortControllerinstance. The propagated abort call will cause the following error:AbortError: signal is aborted without reason. The outer signal might have a reason. I believe it would make sense to pass along theouterSignal.reasonto the internalabortcall. This would reduce confusion in error handling when the outer signal actually has a reason.This applies to:
rxjs/packages/rxjs/src/internal/observable/dom/fetch.ts
Line 119 in c15b37f
Beta Was this translation helpful? Give feedback.
All reactions