Merge pull request #3322 from alexeagle/bazel

chore(bazel): allow downstream projects to omit //:node_modules
ReactiveX · Mar 1, 2018 · c009ac6 · c009ac6
2 parents c7e33e4 + 935e805
commit c009ac6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/BUILD.bazel b/src/BUILD.bazel
@@ -9,4 +9,10 @@ ts_library(
   module_name = "rxjs",
   srcs = glob(["*.ts", "**/*.ts"]),
   tsconfig = "tsconfig.json",
+  # Specify the compile-time dependencies to run the compilation (eg. typescript)
+  # The default value assumes that the end-user has a target //:node_modules
+  # but not all users do.
+  # This also makes the build more reproducible, in case the user's TypeScript
+  # version isn't compatible.
+  node_modules = "@build_bazel_rules_typescript_tsc_wrapped_deps//:node_modules",
 )
diff --git a/tsconfig.json b/tsconfig.json
@@ -23,6 +23,9 @@
     "indentSize": 2,
     "tabSize": 2
   },
+  "bazelOptions": {
+    "suppressTsconfigOverrideWarnings": true
+  },
   "files": [
     "src/Rx.ts"
   ]