2.x: dedicated Single.zip implementation, no dispose on all-success #5027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.59% (diff: 99.24%)@@ 2.x #5027 diff @@
==========================================
Files 609 611 +2
Lines 39427 39538 +111
Methods 0 0
Messages 0 0
Branches 6030 6051 +21
==========================================
+ Hits 37731 37796 +65
- Misses 738 757 +19
- Partials 958 985 +27
|
JakeWharton
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dedicated implementation for zipping
Singles (adapted fromMaybeZipX).Routing the original
zipthroughFlowableadded the usually unwanted behavior of cancelling the sources if one of them reports a completion after a row has been consumed from all (when converted toFlowable,SingleObserver.onSuccessbecomesSubscriber.onNext+onComplete). Since there is onlyonSuccessandonErrorinSingle, there is no need to dispose the sources once all signalled their onlyonSuccess.Related: #5024.