Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Update marble diagrams for sample overloads #4990

Merged
merged 2 commits into from
Jan 16, 2017

Conversation

akarnokd
Copy link
Member

This PR updates the referenced marble diagrams to reflect the actual behavior and options with sample.

New images:

  • sample(time, emitLast)

image

  • sample(time, scheduler, emitLast)

image

  • sample(other) - the original image indicated the emission of the last item which was not the case

image

  • sample(other, emitLast)

image

@akarnokd akarnokd added this to the 2.0 backlog milestone Jan 13, 2017
@codecov-io
Copy link

codecov-io commented Jan 13, 2017

Current coverage is 95.48% (diff: 100%)

Merging #4990 into 2.x will decrease coverage by 0.04%

@@                2.x      #4990   diff @@
==========================================
  Files           592        592          
  Lines         37969      37969          
  Methods           0          0          
  Messages          0          0          
  Branches       5752       5752          
==========================================
- Hits          36273      36256    -17   
- Misses          741        753    +12   
- Partials        955        960     +5   

Powered by Codecov. Last update cd45675...cf98390

@akarnokd
Copy link
Member Author

switchIfEmpty:

image

Maybe:

image

Maybe.switchIfEmpty

image

@DavidMGross
Copy link
Collaborator

FWIW, when I last had time to work on the marble diagrams, I began using this iconography for the various new observable variants:
blankables
This is reflected in some of the existing marble diagrams.

@akarnokd
Copy link
Member Author

Those tail symbols look odd to me and look easy to miss or categorize as diagram errors.

@akarnokd akarnokd merged commit a8ba158 into ReactiveX:2.x Jan 16, 2017
@akarnokd akarnokd deleted the SampleMarbleUpdate branch January 16, 2017 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants