Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: coverage, fixes and cleanup 10/11-2 #4692

Merged
merged 1 commit into from
Oct 12, 2016
Merged

2.x: coverage, fixes and cleanup 10/11-2 #4692

merged 1 commit into from
Oct 12, 2016

Conversation

akarnokd
Copy link
Member

  • cover remaining Maybe operators
  • cover Single operators
  • cover some of the Completable operators
  • fix missing onSubscribe calls
  • compact a few operator implementations
  • fix the order of inner Throwables on certain CompositeException emissions

@akarnokd akarnokd added this to the 2.0 RC5 milestone Oct 11, 2016
@codecov-io
Copy link

codecov-io commented Oct 12, 2016 •
edited
Loading

Current coverage is 83.53% (diff: 98.17%)

Merging #4692 into 2.x will increase coverage by 0.67%

@@                2.x      #4692   diff @@
==========================================
  Files           566        567     +1   
  Lines         37564      37618    +54   
  Methods           0          0          
  Messages          0          0          
  Branches       5782       5790     +8   
==========================================
+ Hits          31124      31423   +299   
+ Misses         4406       4196   -210   
+ Partials       2034       1999    -35

Powered by Codecov. Last update 6ad74b3...7421090

JakeWharton
JakeWharton approved these changes Oct 12, 2016
View reviewed changes
Copy link
Contributor

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one took a while!

@akarnokd
Copy link
Member Author

It was sitting in the Travis job queue.

@akarnokd akarnokd merged commit a2cb6ab into ReactiveX:2.x Oct 12, 2016
@akarnokd akarnokd deleted the Coverage10_11_2 branch October 12, 2016 07:04
@vanniktech vanniktech mentioned this pull request Oct 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees
No one assigned
Labels
Bug Cleanup Coverage
Projects
None yet
Milestone
2.0 RC5
Development

Successfully merging this pull request may close these issues.
3 participants
@akarnokd @codecov-io @JakeWharton