1.x: observeOn - fix in-sequence termination/unsubscription #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -834,4 +834,16 @@ public void testErrorDelayedAsync() { | |||
| ts.assertError(TestException.class); | |||
| ts.assertNotCompleted(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void requestExactCompletesImmediately() { | |||
There was a problem hiding this comment.
Not sure if it tests "immediately", this test passes without changes in this PR.
Maybe you can avoid going to another thread and awaitTerminalEvent()?
There was a problem hiding this comment.
Yeah, should request 0 upfront and wait till the range completes before requesting 10. I'll change this to use the TestScheduler.
There was a problem hiding this comment.
Updated the test which now clearly fails on master.
|
👍 for changes, not sure about test |
akarnokd
force-pushed
the
ObserveOnRequestBoundaryCompletionFix
branch
from
672fa8e
to
e98b20d
Compare
|
👍 |
1 similar comment
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Mar 16, 2016
…tionFix 1.x: observeOn - fix in-sequence termination/unsubscription
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
observeOnnot completing immediately if the downstream requested exactly the remaining amount. The original version required a new request from downstream to trigger the delivery of the terminal event.This also fixes the rare failure in
testNoMoreRequestsAfterUnsubscribebecause the unsubscription is now checked in-sequence and doesn't trigger the unwanted replenishment request.