Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeardownLogic not exported when using rxjs-compat #3531

Closed
cartant opened this issue Apr 6, 2018 · 1 comment
Closed

TeardownLogic not exported when using rxjs-compat #3531

cartant opened this issue Apr 6, 2018 · 1 comment

Comments

@cartant
Copy link
Collaborator

cartant commented Apr 6, 2018

RxJS version: rxjs@6.0.0-rc.0 and rxjs-compat@6.0.0-rc.0

Code to reproduce:

import { Subscription, TeardownLogic } from "rxjs/Subscription";

Expected behavior:

TeardownLogic should be importable as in 5.5.8.

Actual behavior:

An error is effected:

[ts] Module '".../rxjs-tslint-rules/fixtures/v6-compat/node_modules/rxjs/Subscription"' has no exported member 'TeardownLogic'.

Additional information:

I discovered this when adding support for v6 and v6+compat to rxjs-tslint-rules. It's no big deal for me, but I thought I'd point it out.

FYI the 5.5.8 export is here.

cartant added a commit to cartant/rxjs that referenced this issue Apr 6, 2018
benlesh pushed a commit that referenced this issue Apr 6, 2018
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant