Skip to content

Commit efa4dc3

Browse files
mchmielarskikwonoj
authored andcommitted
fix(typings): set map function parameter for Observable.from as optional
without this change typescript returns TS2346 error when we use Observable.from with one parameter. I think that it will be nice if tests will be written in typescript because it will eliminate situations like this.
1 parent 519000b commit efa4dc3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/observable/FromObservable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class FromObservable<T> extends Observable<T> {
2020
super(null);
2121
}
2222

23-
static create<T>(ish: any, mapFnOrScheduler: Scheduler | ((x: any, y: number) => T), thisArg?: any, lastScheduler?: Scheduler): Observable<T> {
23+
static create<T>(ish: any, mapFnOrScheduler?: Scheduler | ((x: any, y: number) => T), thisArg?: any, lastScheduler?: Scheduler): Observable<T> {
2424
let scheduler: Scheduler = null;
2525
let mapFn: (x: number, y: any) => T = null;
2626
if (isFunction(mapFnOrScheduler)) {

0 commit comments

Comments
 (0)