Skip to content

Commit

Permalink
fix(window): handle closingNotifier errors/completes
Browse files Browse the repository at this point in the history
Fix window operator to handle error() and complete() notifications
happening on the closingNotifier Observable given as parameter to
window. This is important in order to pass all tests (that mirror RxJS
legacy tests).
  • Loading branch information
Andre Medeiros authored and benlesh committed Oct 13, 2015
1 parent 388944d commit 42beff1
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/operators/window.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,12 @@ class WindowClosingNotifierSubscriber<T> extends Subscriber<T> {
_next() {
this.parent.openWindow();
}

_error(err: any) {
this.parent._error(err);
}

_complete() {
this.parent._complete();
}
}

0 comments on commit 42beff1

Please sign in to comment.