Make ViewObservables consistent with each other #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I see you moved operators to rx.android package. And removed generics as we discussed. I'll do the same with |
| @@ -77,30 +81,30 @@ public void testWithoutInitialValue() { | |||
| @Test | |||
| @SuppressWarnings("unchecked") | |||
| public void testWithInitialValue() { | |||
There was a problem hiding this comment.
just a general style remark. The test name isn't very good at documenting the desired behavior. It could as well be called "testThatItWorks" and would convey the same information :-) I prefer tests that are small and focused, with ideally only a single given-when-then case. This helps tremendously when trying to understand what the exact behavior under different cases is (happy path, sad path, corner cases)
|
👍 |
|
Is this ready to go in? |
|
@mttkay I think so. |
mttkay
added a commit
that referenced
this pull request
Oct 15, 2014
Make ViewObservables consistent with each other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #20. Resolves #7 as well.