Avoid changing the owner of unnecessary files #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source files shouldn't matter for the purposes of this tool. % ls -R $ANDROID_HOME/sources/android-34 | wc -l 17750
|
@ychescale9, any chance the failing test is a flake? It doesn't seem related to this change. |
|
Thanks for the contribution! Could you please run I can reproduce the failing test from main branch so I think there's likely an issue with the latest version of the system image Google released. So probably not much we can do on our end. |
mikehardy
pushed a commit
to mikehardy/android-emulator-runner
that referenced
this pull request
Oct 10, 2024
* Avoid changing the owner of unnecessary files Source files shouldn't matter for the purposes of this tool. % ls -R $ANDROID_HOME/sources/android-34 | wc -l 17750 * Remove non-existant directory * Avoid another unnecessary chown * Push js
ychescale9
added a commit
that referenced
this pull request
Oct 12, 2024
* main: Prepare for release 2.33.0. Fix avd path on ubuntu-24.04 - attempt 2 (#415) Revert creating avd directory. (#414) Fix SDK path issues with ubuntu-24.04 (#409) SDK build tools 35.0.0, command-line tools 16.0. (#408) Avoid changing the owner of unnecessary files (#406) Update npm packages. (#401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's probably even more precision to be had, but this seems like a good step forward. This is a different approach to the same problem as #344. I'd be happy to close this in favor of that one!
Source files shouldn't matter for the purposes of this tool. There are a number of files.