Skip to content

Commit e1248ae

Browse files
committed
Replace deprecated ANDROID_SDK_ROOT with ANDROID_HOME.
1 parent 8d5c4be commit e1248ae

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

lib/emulator-manager.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ function launchEmulator(apiLevel, target, arch, profile, cores, ramSize, heapSiz
7373
}
7474
// start emulator
7575
console.log('Starting emulator.');
76-
yield exec.exec(`sh -c \\"${process.env.ANDROID_SDK_ROOT}/emulator/emulator -avd "${avdName}" ${emulatorOptions} &"`, [], {
76+
yield exec.exec(`sh -c \\"${process.env.ANDROID_HOME}/emulator/emulator -avd "${avdName}" ${emulatorOptions} &"`, [], {
7777
listeners: {
7878
stderr: (data) => {
7979
if (data.toString().includes('invalid command-line parameter')) {

lib/sdk-installer.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ function installAndroidSdk(apiLevel, target, arch, channelId, emulatorBuild, ndk
5151
console.log(`::group::Install Android SDK`);
5252
const isOnMac = process.platform === 'darwin';
5353
if (!isOnMac) {
54-
yield exec.exec(`sh -c \\"sudo chown $USER:$USER ${process.env.ANDROID_SDK_ROOT} -R`);
54+
yield exec.exec(`sh -c \\"sudo chown $USER:$USER ${process.env.ANDROID_HOME} -R`);
5555
}
56-
const cmdlineToolsPath = `${process.env.ANDROID_SDK_ROOT}/cmdline-tools`;
56+
const cmdlineToolsPath = `${process.env.ANDROID_HOME}/cmdline-tools`;
5757
if (!fs.existsSync(cmdlineToolsPath)) {
5858
console.log('Installing new cmdline-tools.');
5959
const sdkUrl = isOnMac ? CMDLINE_TOOLS_URL_MAC : CMDLINE_TOOLS_URL_LINUX;
@@ -62,7 +62,7 @@ function installAndroidSdk(apiLevel, target, arch, channelId, emulatorBuild, ndk
6262
yield io.mv(`${cmdlineToolsPath}/cmdline-tools`, `${cmdlineToolsPath}/latest`);
6363
}
6464
// add paths for commandline-tools and platform-tools
65-
core.addPath(`${cmdlineToolsPath}/latest:${cmdlineToolsPath}/latest/bin:${process.env.ANDROID_SDK_ROOT}/platform-tools`);
65+
core.addPath(`${cmdlineToolsPath}/latest:${cmdlineToolsPath}/latest/bin:${process.env.ANDROID_HOME}/platform-tools`);
6666
// set standard AVD path
6767
core.exportVariable('ANDROID_AVD_HOME', `${process.env.HOME}/.android/avd`);
6868
// accept all Android SDK licenses
@@ -76,7 +76,7 @@ function installAndroidSdk(apiLevel, target, arch, channelId, emulatorBuild, ndk
7676
// TODO find out the correct download URLs for all build ids
7777
const downloadUrlSuffix = Number(emulatorBuild.charAt(0)) > 6 ? `_x64-${emulatorBuild}` : `-${emulatorBuild}`;
7878
yield exec.exec(`curl -fo emulator.zip https://dl.google.com/android/repository/emulator-${isOnMac ? 'darwin' : 'linux'}${downloadUrlSuffix}.zip`);
79-
yield exec.exec(`unzip -o -q emulator.zip -d ${process.env.ANDROID_SDK_ROOT}`);
79+
yield exec.exec(`unzip -o -q emulator.zip -d ${process.env.ANDROID_HOME}`);
8080
yield io.rmRF('emulator.zip');
8181
}
8282
console.log('Installing system images.');

src/emulator-manager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export async function launchEmulator(
6666
// start emulator
6767
console.log('Starting emulator.');
6868

69-
await exec.exec(`sh -c \\"${process.env.ANDROID_SDK_ROOT}/emulator/emulator -avd "${avdName}" ${emulatorOptions} &"`, [], {
69+
await exec.exec(`sh -c \\"${process.env.ANDROID_HOME}/emulator/emulator -avd "${avdName}" ${emulatorOptions} &"`, [], {
7070
listeners: {
7171
stderr: (data: Buffer) => {
7272
if (data.toString().includes('invalid command-line parameter')) {

src/sdk-installer.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ export async function installAndroidSdk(apiLevel: number, target: string, arch:
1818
const isOnMac = process.platform === 'darwin';
1919

2020
if (!isOnMac) {
21-
await exec.exec(`sh -c \\"sudo chown $USER:$USER ${process.env.ANDROID_SDK_ROOT} -R`);
21+
await exec.exec(`sh -c \\"sudo chown $USER:$USER ${process.env.ANDROID_HOME} -R`);
2222
}
2323

24-
const cmdlineToolsPath = `${process.env.ANDROID_SDK_ROOT}/cmdline-tools`;
24+
const cmdlineToolsPath = `${process.env.ANDROID_HOME}/cmdline-tools`;
2525
if (!fs.existsSync(cmdlineToolsPath)) {
2626
console.log('Installing new cmdline-tools.');
2727
const sdkUrl = isOnMac ? CMDLINE_TOOLS_URL_MAC : CMDLINE_TOOLS_URL_LINUX;
@@ -31,7 +31,7 @@ export async function installAndroidSdk(apiLevel: number, target: string, arch:
3131
}
3232

3333
// add paths for commandline-tools and platform-tools
34-
core.addPath(`${cmdlineToolsPath}/latest:${cmdlineToolsPath}/latest/bin:${process.env.ANDROID_SDK_ROOT}/platform-tools`);
34+
core.addPath(`${cmdlineToolsPath}/latest:${cmdlineToolsPath}/latest/bin:${process.env.ANDROID_HOME}/platform-tools`);
3535

3636
// set standard AVD path
3737
core.exportVariable('ANDROID_AVD_HOME', `${process.env.HOME}/.android/avd`);
@@ -51,7 +51,7 @@ export async function installAndroidSdk(apiLevel: number, target: string, arch:
5151
// TODO find out the correct download URLs for all build ids
5252
const downloadUrlSuffix = Number(emulatorBuild.charAt(0)) > 6 ? `_x64-${emulatorBuild}` : `-${emulatorBuild}`;
5353
await exec.exec(`curl -fo emulator.zip https://dl.google.com/android/repository/emulator-${isOnMac ? 'darwin' : 'linux'}${downloadUrlSuffix}.zip`);
54-
await exec.exec(`unzip -o -q emulator.zip -d ${process.env.ANDROID_SDK_ROOT}`);
54+
await exec.exec(`unzip -o -q emulator.zip -d ${process.env.ANDROID_HOME}`);
5555
await io.rmRF('emulator.zip');
5656
}
5757
console.log('Installing system images.');

0 commit comments

Comments
 (0)