Release Peak Envelope Generator v1.0#1556
Closed
saul-l wants to merge 1 commit into
Closed
Conversation
cfillion
reviewed
May 1, 2025
| @@ -0,0 +1,277 @@ | |||
| -- @description Peak Envelope Generator | |||
Member
There was a problem hiding this comment.
Suggested change
| -- @description Peak Envelope Generator | |
| -- @description Peak envelope generator |
...to match the convention of native REAPER actions and other scripts. (Same with the filename.)
| if reaper.GetOS() == "Win32" or reaper.GetOS() == "Win64" then | ||
| os.execute('start https://reapack.com') | ||
| else | ||
| os.execute('open https://reapack.com') |
Member
There was a problem hiding this comment.
On Linux it's xdg-open.
(There's CF_ShellExecute('url') in SWS that's cross-platform & avoids using the system shell but I don't think it would be appropriate here since it'd be yet another dependency that could be missing.)
(ReaPack_BrowsePackages itself won't emit any errors, but a simpler presence check could be if not ReaPack_BrowsePackages then.)
| if smooth then reaper.Main_OnCommand(40331,0) end | ||
| selectedItems = SaveSelectedItems() | ||
| CalculateEnvelope() | ||
| reaper.Undo_EndBlock("peakEnvelope", -1) |
Member
There was a problem hiding this comment.
This string is the undo point name shown to the user; wouldn't it be better if it matched the script's name "Peak envelope generator"?
Suggested change
| reaper.Undo_EndBlock("peakEnvelope", -1) | |
| reaper.Undo_EndBlock("Peak envelope generator", -1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.