-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disasterous restore #86
Comments
Hi. Really sorry for this. This should not happen but it seems that there was an error and when saving a session it saved something that it should not. From what I know I already have a fix created inside the addon, but i need a little bit more time to check it again. I will be back shortly with more info. |
I tested with the link you provided above and the problem was fixed. It should be the same in your case for all the sessions that have this issue. If it worked or not please update me so that I can see what else I can do. I have not discovered yet the exact conditions when this happens but it's related to using lazy-restore + saving without activating the lazy-loading tabs. I will try to make an update to make sure this can't happen again. |
Does the fix that I described above not work ?! Have you tried it ? |
I never saw any difference. I have real work to do, and so didn't have much time to help you debug your code. It's such a mess now, that I have to. I turned on Troubleshooting. Now what? |
By "link" do you mean something like this:
|
Look on the second comment. You have clear images what to do, and should be easy and very fast. |
I'm really sorry for the bug. I just don't really have time to fix it automatically right now. I will try to hurry up with an update. But trust me here. What you gave me it's fixable on your side. Just follow the instruction from the second comment and it should work without any issues. |
Okay, I did that. A Restore takes 3 minutes. Then I end up with lots of windows, many tabs have what I posted above. |
Did you press on the session again to reload it ? Were any tabs restored to the right information? |
I pressed the Restore button to restore it. A couple hundred of my tabs over about 10 windows. When I start FF, only one tab per window is loaded, so restarting FF is really fast. I expect your tool to perform comparably. You have 3 tabs: the one with your Session Sync logo, one called Sessions, and one called History. |
Sadly the solution does not work on the History tabs from what I know. If you save them as bookmarked sessions (Session tab) then the repair should work. If you don't have any saved session the Session tab does not do anything.
|
Actually, in the current session, there are lots of tabs with the url being what I showed above. Can they be fixed? Also, my main reason for wanting to save my sessions (automatically) is so that when I restart FF, I will be back where I was, with all my FF windows, and all their tabs, pinned and unpinned, appropriately. Occasionally, FF loses all my windows and tabs. When this happens, I would like to restore to the last known good session. Other than being able to restore from an automatic backup, I'm not sure why I would want a fixed snapshot of all my FF windows and their tabs. I've noticed that when I restart FF now, I get some session that's not what was in FF when I last quit. It's a minimal set of just the pinned tabs from some sort of recent session, which is not what I want. I want all the pinned and unpinned tabs from my last session. |
You said "The Logo tab shows you the active session (windows) - nothing to repair here since it just shows you what you have currently open" |
I understand the reason for proffering History, but sadly that part was redesigned multiple times to match what people expected from it, I never used it so I had some trouble finding the right way to implement it and it turned out to be somewhat unreliable. I need to rewrite it completely because there are some issues with it :(. As for the normal pinned tab, I can't tell you exactly what is happening, it seems really odd for me as well, I will investigate it more. All the links that you gave me should be fixable, I tested them manually, edited a session entry, put that link and then when I press the fix session the link turns correctly into www.lwmcnc.com. I understand that you might want to recover the History sessions, I'm really sorry but that can't be done right now, all you can is to save them as sessions, and then fix them from there. But yes, sadly you will lose the pinned tab feature doing that (It's not that I don't want to save pinned information or other properties of the tab, I did that in version 1 of the addon, but Mozilla simply removed the possibility to do so for bookmarks and I have no way of storing reliable data about a bookmark right now. The history session are stored in addon-data, which is automatically deleted if you reinstall/remove the addon and bookmarks are not, that's why I store everything as bookmarks. The History Tab was mainly meant to be an alternative, right now it's not that great, and on top of it there's this issues as well that happens sometimes. In reality, the truth is, the addon as it's designed right now might not be what you need, and you might be able to find something better out there. There are multiple things that I want to fix in the addon, but the History tab is not really a big priority right now (beside this issues with restoring that can happen everywhere). I'm sorry about your bad experience, maybe I fail to explain right now how to fix them properly but I'm not really sure I can do much without an update that will fix this.
|
On a side note... if you disable the lazy-loading, this issue will never happen again. It's mainly caused by having lazy-loading and auto-saving an unloaded lazy-tab... but I can't find out why it's saved like that and not reverted back to what the file is suppose to be. Will try to double check the behavior, since maybe I missed some edge case. |
I opened Firefox, to find that none of my non-pinned tabs had been restored.
So, I opened SessionSync, found a session that had the non-pinned tabs and selected Restore in New Window.
The text was updated successfully, but these errors were encountered: