-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Tree Style Tab #43
Comments
Hi, thanks for feedback. What that means... well if I try to provide this feature, I won't be able to know any change that another addon does to his own tree structure representation. The only way this might work is only if I provide a full featured tree style tab implementation inside my addon and you will only use that one for various operations such as (reorganizing the tree) So basically... I might be able to do that, I can't know for sure how hard is for me to implement
|
Tab session manager ( https://github.com/sienori/Tab-Session-Manager ) is an addon that is compatible with Tree Style Tabs ( https://github.com/piroor/treestyletab ). However it does not sync across devices.
|
Mmm... thanks for pointing out all those resources. |
Hi @ReDEnergy! I wanted to thank you for making this extension. I wish I had more to add, but I really just came here explicitly to request this feature. 😅 As an aside, I was reading through the reviews on the Firefox extension page while deciding which extension to use and I was impressed with how you responded to questions and problems. In fact, it's what made me choose this one above the others. Keep being awesome. 🥇 |
@TehCorwiz Thanks for using the addon. |
@ReDEnergy I've been there and completely understand. No worries at all. I have the utmost respect for people who volunteer their time or release their own tools. If I get some time maybe I'll hack on it myself. Are you open to PRs if someone else were to get it working? |
PRs are welcomed. Of course, that being said, I wouldn't say that the code is really hard to read, but when you don't have comments, the 20K of vanilla JavaScript with HTML purely generated from JavaScript and half of the DOM in position absolute can get pretty complicated :). Of course, If you ask me, I had to do all this in order to achieve the target performance as well as to implement all the features that the addon does right now. |
Me too use "Tab session manager" integration on "Tree Style Tab" and they work great together. |
First, great addon, thank you so much for being a viable alternative to the venerable session manager.
Second, I wanted to "second" some of the items you already have on your todo list:
I would like to request something that has been critical for me and so far no sesison managers handle it cleanly, support for Tree Style's trees. That is if I have a few tabs stacked in a "tree", I was able to restore that tree (without extraneous new tabs appearing which one of the session managers that kind of remembers a tree structure does) with Session manager. One of the things I love about your addon is it uses bookmarks so is easier to manage and much more portable so I am really really really hoping that tree style integration can be done.
The text was updated successfully, but these errors were encountered: