loose attributes work now (requestFormatInstance is now created properly using a stdClass)

Author: eceltov

app/V1Module/presenters/RegistrationPresenter.php

@@ -165,7 +165,7 @@ public function checkCreateAccount()
      * @throws WrongCredentialsException
      * @throws InvalidArgumentException
      */
-    #[FormatAttribute("userRegistration")]
+    #[FormatAttribute(UserFormat::class)]
     public function actionCreateAccount()
     {
         $req = $this->getMetaRequest();

app/V1Module/presenters/base/BasePresenter.php

@@ -75,8 +75,8 @@ class BasePresenter extends \App\Presenters\BasePresenter
      */
     public $logger;
 
-    /** @var MetaFormat Processed parameters from the request */
-    private MetaFormat $requestFormatInstance;
+    /** @var mixed Processed parameters from the request (MetaFormat or stdClass) */
+    private mixed $requestFormatInstance;
 
     protected function formatPermissionCheckMethod($action)
     {
@@ -236,9 +236,12 @@ private function processParams(ReflectionMethod $reflection)
 
     private function processParamsLoose(array $paramData)
     {
+        $formatInstanceArr = [];
+
         // validate each param
         foreach ($paramData as $param) {
             $paramValue = $this->getValueFromParamData($param);
+            $formatInstanceArr[$param->name] = $paramValue;
 
             // check if null
             if ($paramValue === null) {
@@ -257,6 +260,9 @@ private function processParamsLoose(array $paramData)
                 }
             }
         }
+
+        // cast to stdClass
+        $this->requestFormatInstance = (object)$formatInstanceArr;
     }
 
     private function processParamsFormat(string $format)

app/helpers/MetaFormats/FieldFormatDefinition.php

@@ -106,6 +106,7 @@ private static function recursiveFormatChecker(mixed $value, FormatParser $parse
         }
 
         // check whether the validator exists
+        ///TODO: replace this mechanism
         $validators = FormatCache::getValidators();
         if (!array_key_exists($parsedFormat->format, $validators)) {
             throw new InternalServerException("The format {$parsedFormat->format} does not have a validator.");

app/helpers/MetaFormats/MetaRequest.php

@@ -7,9 +7,9 @@
 class MetaRequest
 {
     private Request $baseRequest;
-    private MetaFormat $requestFormatInstance;
+    private mixed $requestFormatInstance;
 
-    public function __construct(Request $request, MetaFormat $requestFormatInstance)
+    public function __construct(Request $request, mixed $requestFormatInstance)
     {
         $this->baseRequest = $request;
         $this->requestFormatInstance = $requestFormatInstance;