Fixing SIS extensions to support SIS courses events which are not scheduled (do not have day, time, or room filled).

Author: Martin Krulis

app/V1Module/presenters/SisPresenter.php

@@ -333,11 +333,16 @@ public function actionCreateGroup($courseId) {
     $group = new Group($remoteCourse->getCourseId(), $parentGroup->getInstance(), $user, $parentGroup);
 
     foreach (["en", "cs"] as $language) {
-      $timeInfo = $this->dayToString($remoteCourse->getDayOfWeek(), $language) . ", " . $remoteCourse->getTime();
-      if ($remoteCourse->isFortnightly()) {
-        $timeInfo .= ', ' . $this->oddWeeksToString($remoteCourse->getOddWeeks(), $language);
+      // Assemble new group name from course data....
+      if ($remoteCourse->getDayOfWeek() !== null && $remoteCourse->getTime() !== null) {
+        $timeInfo = $this->dayToString($remoteCourse->getDayOfWeek(), $language) . ", " . $remoteCourse->getTime();
+        if ($remoteCourse->isFortnightly()) {
+          $timeInfo .= ', ' . $this->oddWeeksToString($remoteCourse->getOddWeeks(), $language);
+        }
+        $caption = sprintf("%s (%s)", $remoteCourse->getCaption($language), $timeInfo);
+      } else {
+        $caption = $remoteCourse->getCaption($language);
       }
-      $caption = sprintf("%s (%s)", $remoteCourse->getCaption($language), $timeInfo);
 
       $localization = new LocalizedGroup($language, $caption, $remoteCourse->getAnnotation($language));
       $group->addLocalizedText($localization);

app/helpers/SisHelper/SisCourseRecord.php

@@ -53,11 +53,15 @@ public static function fromArray($sisUserId, $data) {
     $result->affiliation = $data["affiliation"];
     $result->year = $data["year"];
     $result->term = $data["semester"];
-    $result->dayOfWeek = intval($data["day_of_week"]) - 1;
-    $minutes = intval($data["time"]);
-    $result->time = (new DateTime())
-      ->setTime(floor($minutes / 60), $minutes % 60)
-      ->format("H:i");
+    $result->dayOfWeek = $data["day_of_week"] !== null ? intval($data["day_of_week"]) - 1 : null;
+    if ($data["time"] !== null) {
+      $minutes = intval($data["time"]);
+      $result->time = (new DateTime())
+        ->setTime(floor($minutes / 60), $minutes % 60)
+        ->format("H:i");
+    } else {
+      $result->time = null;
+    }
     $result->fortnightly = $data["fortnight"];
     $result->oddWeeks = $data["firstweek"] == 1;
     $result->type = array_key_exists($data["type"], static::$typeMap) ? static::$typeMap[$data["type"]] : "unknown";