Skip to content

Allow loading of uncompressed rcnet file to allow version control tools to work nicely w/ ReClass.NET files #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dschu012
Copy link

@dschu012 dschu012 commented Jun 7, 2022

When working on rcnet files w/ multiple people, right now it is impossible to see changes from version to version since they are a zip archive. This PR is an attempt at allowing a rcnetxml to be Saved/Loaded with the raw XML to allow version tracking tools like git to work nicely w/ the files.

@@ -1,9 +1,11 @@
namespace ReClassNET.DataExchange.ReClass
namespace ReClassNET.DataExchange.ReClass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these changes here and in ReClass.NET_Launcher/Program.cs? BOM or something?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems so? Idk why those got added. I tried to revert them and vscode wasn't showing those lines as changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants