Set up extraction of plural strings from C #6805
Conversation
issue no-6794. solving this issue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6805 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 79 79
Lines 14639 14639
=======================================
Hits 14440 14440
Misses 199 199 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Is this pull request complete? If not, it's best to mark it as draft to avoid wasting reviewer time.
Instead of mentioning the issue number in the title, please mention it in the text of the pull request. GitHub doesn't do much with issue numbers in the pull request titles, but it will gladly link the two together if you move it into the comment section.
There was a problem hiding this comment.
Please don't commit extraneous files (produced by your editor?). When contributing to an open source project, try to minimise your changes as much as possible. This file should be removed from the pull request (but feel free to keep it locally, uncommitted).
| #define _(String) dgettext("data.table", String) | ||
| // NB: flip argument order to match that of R's ngettext() | ||
| #define Pl_(n, String1, StringPlural) dngettext("data.table", String1, StringPlural, n) | ||
| #define Pl_Extract(String1, StringPlural) (String1 "\0" StringPlural) // Helps extract both strings |
There was a problem hiding this comment.
Could you please explain your plan for making this work? As submitted, this doesn't help potools::po_extract actually find the strings marked using the Pl_ macro.
There was a problem hiding this comment.
@aitap Sorry for this mistake. I appreciate your feedback and will make the necessary improvements.
MichaelChirico
changed the title
|
I will close here for now. As noted, this issue in particular doesn't have much to do on the {data.table} side -- almost all of the work will happen in {potools}. If you'd like to contribute there, awesome! But if you're mainly interested in contributing directly to {data.table}, there may be other issues more worth your time. Thanks! |
3 participants
Closes #6794
The macro adds the plural string by concatenating it with the singular form using "\0".
This ensures both forms are present in the source code for translation tools like xgettext.
It does not affect runtime behavior but helps extract both singular and plural strings.
When used, only the singular appears in printf(), but both forms exist in memory.