Skip to content

Conversation

@MichaelChirico
Copy link
Member

Closes #6797

Not testable AFAIK.

@MichaelChirico MichaelChirico added this to the 1.17.0 milestone Feb 7, 2025
@MichaelChirico MichaelChirico changed the title Cannot UNPROTECT recycleAscArg SEXP which livs on as ascArg Fix forder segfault Feb 7, 2025
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (4f7f567) to head (2894963).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6800      +/-   ##
==========================================
- Coverage   98.64%   98.64%   -0.01%     
==========================================
  Files          79       79              
  Lines       14640    14639       -1     
==========================================
- Hits        14441    14440       -1     
  Misses        199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Feb 7, 2025

Comparison Plot

Generated via commit 2894963

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 27 seconds
Installing different package versions 8 minutes and 14 seconds
Running and plotting the test cases 2 minutes and 21 seconds

@aitap
Copy link
Contributor

aitap commented Feb 7, 2025 via email

@MichaelChirico
Copy link
Member Author

OK I think we have consensus to review from a few committees between comments/reactions here & on issue. Going ahead.

@MichaelChirico MichaelChirico merged commit b7f2106 into master Feb 9, 2025
11 checks passed
@MichaelChirico MichaelChirico deleted the fordre-recycle-segfault branch February 9, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential segfault in forder

3 participants