-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setDF deletes the index attribute #4893
Conversation
change looks great! please also add the following:
|
Codecov Report
@@ Coverage Diff @@
## master #4893 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 75 75
Lines 14808 14812 +4
=======================================
+ Hits 14730 14734 +4
Misses 78 78
Continue to review full report at Codecov.
|
What change is needed to ?setDF ? Where was it discussed? |
The tests are failing due to the external references changes. Those changes seem like a separate PR and outside the scope of removing the index attribute during See the comment here #4889 (comment) for the
|
This made me learn the hard way that any commits I push to the same branch are automatically added to the same PR :( |
PR is always based on a branch. If you don't want commits to go into same PR then you have to make new branch for them. |
Fix buffer overrun warning.
This is a small but rather important fix ( |
@MichaelChirico is there anything I can do to help merge this? |
Closes #4889