Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env & substitute2 are not available in 1.14.6 #5538

Closed
Fred-Wu opened this issue Nov 25, 2022 · 4 comments · Fixed by #5432
Closed

env & substitute2 are not available in 1.14.6 #5538

Fred-Wu opened this issue Nov 25, 2022 · 4 comments · Fixed by #5432
Labels
Milestone

Comments

@Fred-Wu
Copy link

Fred-Wu commented Nov 25, 2022

I am trying the new programming facilities in data.table, especially env and substitute2.

However, in the latest version of 1.14.6, those two seems not available.

unused argument (env = list(v = as.list(v)))

There are questions about using env with 1.14.3 on stackoverflow.

So were they removed from 1.14.6?

@Fred-Wu Fred-Wu changed the title 'env' & 'substitute2' are not available in V 1.14.6 env & substitute2 are not available in 1.14.6 Nov 25, 2022
@ben-schwen
Copy link
Member

This is a duplicate of #5369

env and substitute2 were originally planned for 1.14.3 which is similar to the current dev version. The last releases were hotfixes or attempts to counter current testing errors on CRAN.

Right now those features are only available in the current dev version. You can update to dev with data.table:::update.dev.pkg() (or with data.table:::update_dev_pkg() depending on which version you have installed).

@tdhock
Copy link
Member

tdhock commented Nov 25, 2022

The way I think of it is that 1.14.6 is a "patch" release, just for keeping CRAN happy, but not introducing any major new features or bugfixes.
If I understand correctly the current versioning system is x.y.even for CRAN release and x.y.odd for github master, is that the only meaning of the version numbers or are there other meanings for the x and y currently?
Maybe it would be good if we had some versioning scheme that would indicate when we do a non-patch release?
For example we could increment the second number in the version? So the next major new feature/bugfix release to CRAN would be 1.15.2? And master could have version 1.15.1? (this may be able to avoid issues like this one, because patch releases would have smaller version numbers than the next feature/bugfix release)

@shrektan
Copy link
Member

Any plan for the major release soon?

I believe fixes like #4803, which was merged into the master branch for 1.5 years, are not included in 1.14.6, yet. This has bitten me for years, and I'm unable to use the dev branch on the production machine, due to the IT policy of our company.

@tdhock
Copy link
Member

tdhock commented Nov 30, 2022

We are working on a release. One of the things we need to do is minimize number of revdep check issues. If you have time to help, you could look at the list of open issues with revdep tag, https://github.com/Rdatatable/data.table/issues?q=is%3Aissue+is%3Aopen+label%3Arevdep some of which need help (fixing dt issues such as #5133 ) or contacting revdep maintainers to ask for updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants