Skip to content

Simplify is_na() #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Simplify is_na() #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcfdc2d
simplify is_na()
krlmlr Jan 11, 2018
38d024f
NEWS
krlmlr Jan 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2018-01-11 Kirill Müller <krlmlr@mailbox.org>

* inst/include/Rcpp/traits/is_na.h: Speed up Rcpp::is_na<double>()
(pull request #799)

2018-01-09 Iñaki Ucar <i.ucar86@gmail.com>

* inst/include/Rcpp/vector/proxy.h: Improve support for NVCC, the CUDA
Expand Down
2 changes: 1 addition & 1 deletion inst/include/Rcpp/traits/is_na.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace Rcpp{

template <>
inline bool is_na<REALSXP>(double x) {
return internal::Rcpp_IsNA(x) || internal::Rcpp_IsNaN(x);
return R_isnancpp(x);
}

template <>
Expand Down