Skip to content

Remove unused and no-longer-needed function compilerCheck #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

eddelbuettel
Copy link
Member

During the previous PR I noticed this unused function from 2016 hanging around. A search under organization cran reveals no package using it, and we are generally in a better situation with respect to what the compilers provide / what we need. So while I am generally very careful about removals, this one should be easy.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused compilerCheck function and its documentation from the Rcpp package. The function was originally created in 2016 to check for minimal g++ compiler versions but is no longer needed due to improved compiler support and lack of usage across CRAN packages.

  • Removes the compilerCheck function from R/compilerCheck.R
  • Removes corresponding documentation from man/compilerCheck.Rd
  • Updates package version from 1.1.0.1 to 1.1.0.2 with appropriate changelog entries

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
R/compilerCheck.R Complete removal of the unused compilerCheck function
man/compilerCheck.Rd Removal of corresponding documentation file
DESCRIPTION Version bump to 1.1.0.2 and date update
inst/include/Rcpp/config.h Updates development version strings to match new version
ChangeLog Documents the removal with appropriate changelog entries

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't exported, so shouldn't break anything.

@eddelbuettel
Copy link
Member Author

Correct.

Next up are the exported and long-deprecated RcppLdPath() and friends and because they were exported I am fearing breakage. We shall see ...

@eddelbuettel eddelbuettel merged commit 29b3b78 into master Jul 21, 2025
22 checks passed
@eddelbuettel eddelbuettel deleted the feature/remove_compilercheck branch July 21, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants