Skip to content

Untag token upon removal from the precious list #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2022
Merged

Untag token upon removal from the precious list #1205

merged 4 commits into from
Mar 14, 2022

Conversation

Enchufa2
Copy link
Member

Closes #1203

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@eddelbuettel
Copy link
Member

Thanks -- I'll turn the rev.dep. machinery on now.

@Enchufa2 Enchufa2 force-pushed the bugfix/untag_token branch from 03f6a1b to 39f8aa5 Compare March 13, 2022 18:09
@eddelbuettel
Copy link
Member

All good from reverse-dependency checking -- just added another commit update minor version and NEWS.Rd.

Will merge once additional CI run is done.

@eddelbuettel eddelbuettel merged commit 6833b47 into master Mar 14, 2022
@Enchufa2 Enchufa2 deleted the bugfix/untag_token branch March 14, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PreserveStorage doesn't clean up ref counters, leading to unnecessary object copies
2 participants
@Enchufa2 @eddelbuettel