Skip to content

Commit 04f39cd

Browse files
committed
remove unused variable (fixes #1137)
1 parent 71eb020 commit 04f39cd

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

ChangeLog

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
2021-01-21 Dirk Eddelbuettel <edd@debian.org>
2+
3+
* inst/include/Rcpp/DataFrame.h: Remove unused variable
4+
5+
* R/Attributes.R (sourceCpp): Support argument echo to be passed to
6+
source() to silence optional R evaluation
7+
18
2021-01-19 Dirk Eddelbuettel <edd@debian.org>
29

310
* DESCRIPTION (Version, Date): Roll minor version

inst/include/Rcpp/DataFrame.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
//
33
// DataFrame.h: Rcpp R/C++ interface class library -- data frames
44
//
5-
// Copyright (C) 2010 - 2015 Dirk Eddelbuettel and Romain Francois
5+
// Copyright (C) 2010 - 2021 Dirk Eddelbuettel and Romain Francois
66
//
77
// This file is part of Rcpp.
88
//
@@ -106,7 +106,7 @@ namespace Rcpp{
106106
Parent::push_front(object, name);
107107
set_type_after_push();
108108
}
109-
109+
110110
// Offer multiple variants to accomodate both old interface here and signatures in other classes
111111
inline int nrows() const { return DataFrame_Impl::nrow(); }
112112
inline int rows() const { return DataFrame_Impl::nrow(); }
@@ -133,7 +133,6 @@ namespace Rcpp{
133133
void set_type_after_push(){
134134
int max_rows = 0;
135135
bool invalid_column_size = false;
136-
SEXP data = Parent::get__();
137136
List::iterator it;
138137
// Get the maximum number of rows
139138
for (it = Parent::begin(); it != Parent::end(); ++it) {

0 commit comments

Comments
 (0)