Validate against invalid fields when initializing the dataset

Author: dariosky

ravenpackapi/models/dataset.py

@@ -38,7 +38,7 @@ def __init__(self, api=None, name=None,
         if 'id' in kwargs:
             if uuid:
                 raise Exception("Please provide or the id or the uuid, not both: they are aliases")
-            uuid = kwargs['id']
+            uuid = kwargs.pop('id')
 
         self.api = api
         self.product_version = product_version
@@ -58,8 +58,11 @@ def __init__(self, api=None, name=None,
 
         self.tags = tags
 
-        self.creation_time = kwargs.get('creation_time')
-        self.last_modified = kwargs.get('last_modified')
+        self.creation_time = kwargs.pop('creation_time', None)
+        self.last_modified = kwargs.pop('last_modified', None)
+
+        if kwargs:
+            raise ValueError("Invalid fields for the dataset: %s" % ", ".join(kwargs.keys()))
 
         # the dataset can be initialized with just the uuid and the name
         # in that case we'll ask the server for the missing info

ravenpackapi/tests/test_dataset_crud.py

@@ -47,3 +47,21 @@ def test_create_and_delete(self):
 
         owned_dataset = self.api.list_datasets()
         assert new_dataset.id not in owned_dataset, "The new dataset should be deleted"
+
+
+class TestDatasetCreation(object):
+
+    def test_valid_additional_fields(self):
+        dt = '2020-01-01'
+        d = Dataset(id='us30', creation_time=dt, last_modified=dt)
+        assert d.id == 'us30'
+        assert d.creation_time == d.last_modified == dt
+
+    def test_valid_uuid(self):
+        d = Dataset(uuid='us30')
+        assert d.id == 'us30'
+
+    def test_invalid_additional_fields(self):
+        dt = '2020-01-01'
+        with pytest.raises(ValueError):
+            Dataset(id='us30', creation_time=dt, last_modified=dt, invalid_field=1)