feat: add the IVariableMap and IVariableModel interfaces. #8369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Jul 15, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
LGTM after copyright statements are added.
| @@ -0,0 +1,66 @@ | |||
| import {IVariableModel} from './i_variable_model.js'; | |||
Contributor
There was a problem hiding this comment.
Copyright statement plox. Here and in the other file.
This was referenced Jul 15, 2024
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8072.
Proposed Changes
This PR adds formal interfaces for variable maps and models.
Reason for Changes
This is needed to enable Scratch to upgrade to modern Blockly, and adds useful extension APIs for all developers.