[Screen reader] The "Begin ..." label is missing information in some cases

[microbit-robert]

Check for duplicates

• I have searched for similar issues before opening a new one.

Description

For c-shaped blocks that don't have text on the statement input line and have value inputs in the previous field row, getFieldRowLabel is only returning part of the block text. Please see the example below, where "Begin pressed" is output, but it would be better if the output was "Being on button A pressed".

Other blocks that have text on the statement input:

or more simple c-shaped blocks without inputs:

are readout correctly.

Reproduction steps

1. Go to https://screen-reader-preview.review-pxt.pages.dev/#editor - this is a version of MakeCode that has the latest screen reader work integrated
2. Add an "on button pressed" block and navigate to it's statement input connection
3. Observe the partial "Begin pressed" output

Priority

No response

Stack trace

Screenshots

No response

Browsers

No response

[microbit-robert]

We intend to open a PR for this.

[BenHenning]

Just to check: is this the primary failure case? I'm actually not finding it particularly confusing from a navigation perspective since the user would have just previously to this point been navigating through the parent block and thus have the context of 'on button...'.

I see the argument that the last label may simply be confusing. I'm not sure the correct solution is to repeat the entire block, though. Maybe it would be clearer to simply remove the extra context entirely if we don't have a direct label for the input? I'm a bit torn on this.

@rachel-fenichel do you have any opinions here?

[microbit-robert]

The image in the above comment seems broken. I see your point though, the full line readout for moving down probably isn't that important because the user will have context, but moving bottom up it's much more useful to know if you are in "button B pressed" rather than "button A pressed" for instance.