Fixing spelling errors in rasa-sdk #833
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ancalita
reviewed
Aug 24, 2022
Member
ancalita
left a comment
ancalita
left a comment
There was a problem hiding this comment.
Looks great 💯
Could you please add a changelog entry of type misc to document the typo corrections?
Author
|
@ancalita Done, sorry for the long wait, but i created the changelog! |
ancalita
reviewed
Sep 16, 2022
|
|
||
| @property | ||
| def active_form(self) -> Dict[Text, Any]: | ||
| warnings.warn( |
Member
There was a problem hiding this comment.
The linter check failed on line 71 because it expected a docstring, could you please add the following docstring:
Returns the active_loop dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)