Skip to content

Add Deprecation Warn to create_guild #10164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Gooraeng
Copy link
Contributor

Summary

I don't think it's necessary, but I thought it would be nice for developers to be aware of it.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Comment on lines 2436 to 2443
import warnings

msg = (
"client.create_guild will be deprecated from July 15, 2025.\n"
"Please refer to https://discord.com/developers/docs/change-log?topic=HTTP+API#deprecating-guild-creation-by-apps"
)
warnings.warn(msg)

Copy link
Contributor

@MCausc78 MCausc78 Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use discord.utils.deprecated function (like here) and document the change in docstring

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Gooraeng Gooraeng changed the title Add Deprecation Message to create_guild Add Deprecation Warn to create_guild Apr 18, 2025
@Soheab
Copy link
Contributor

Soheab commented Apr 24, 2025

Template.create_guild also needs such warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants