-
Notifications
You must be signed in to change notification settings - Fork 70
Add support to configure adding jackson @JsonPOJOBuilder annotations to generated builders #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maff
wants to merge
1
commit into
Randgalt:master
Choose a base branch
from
maff:feature-jackson-annotations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
record-builder-test/src/main/java/io/soabase/recordbuilder/test/JacksonAnnotated.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright 2019 The original author or authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.soabase.recordbuilder.test; | ||
|
|
||
| import com.fasterxml.jackson.databind.annotation.JsonDeserialize; | ||
| import io.soabase.recordbuilder.core.RecordBuilder; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| public interface JacksonAnnotated { | ||
| String name(); | ||
|
|
||
| String type(); | ||
|
|
||
| Map<String, Object> properties(); | ||
|
|
||
| @RecordBuilder | ||
| @RecordBuilder.Options(addJacksonAnnotations = true, useImmutableCollections = true, prefixEnclosingClassNames = false) | ||
| @JsonDeserialize(builder = JacksonAnnotatedRecordBuilder.class) | ||
| record JacksonAnnotatedRecord(String name, @RecordBuilder.Initializer("DEFAULT_TYPE") String type, | ||
| Map<String, Object> properties) implements JacksonAnnotated { | ||
| public static final String DEFAULT_TYPE = "dummy"; | ||
| } | ||
|
|
||
| @RecordBuilder | ||
| @RecordBuilder.Options(addJacksonAnnotations = true, useImmutableCollections = true, prefixEnclosingClassNames = false, setterPrefix = "set") | ||
| @JsonDeserialize(builder = JacksonAnnotatedRecordCustomSetterPrefixBuilder.class) | ||
| record JacksonAnnotatedRecordCustomSetterPrefix(String name, @RecordBuilder.Initializer("DEFAULT_TYPE") String type, | ||
| Map<String, Object> properties) implements JacksonAnnotated { | ||
| public static final String DEFAULT_TYPE = "dummy"; | ||
| } | ||
| } |
68 changes: 68 additions & 0 deletions
68
record-builder-test/src/test/java/io/soabase/recordbuilder/test/TestJacksonAnnotations.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /* | ||
| * Copyright 2019 The original author or authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.soabase.recordbuilder.test; | ||
|
|
||
| import com.fasterxml.jackson.core.JsonProcessingException; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.fasterxml.jackson.databind.annotation.JsonPOJOBuilder; | ||
| import io.soabase.recordbuilder.test.JacksonAnnotated.JacksonAnnotatedRecord; | ||
| import io.soabase.recordbuilder.test.JacksonAnnotated.JacksonAnnotatedRecordCustomSetterPrefix; | ||
| import org.assertj.core.api.InstanceOfAssertFactories; | ||
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.Arguments; | ||
| import org.junit.jupiter.params.provider.MethodSource; | ||
| import org.junit.jupiter.params.provider.ValueSource; | ||
|
|
||
| import java.util.Arrays; | ||
| import java.util.stream.Stream; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.junit.jupiter.params.provider.Arguments.arguments; | ||
|
|
||
| class TestJacksonAnnotations { | ||
| private final ObjectMapper objectMapper = new ObjectMapper(); | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource("recordBuilders") | ||
| void addsJsonPOJOBuilderAnnotation(Class<? extends JacksonAnnotated> type, String expectedPrefix) { | ||
| final var annotations = Arrays.stream(type.getAnnotations()).toList(); | ||
| assertThat(annotations).filteredOn(annotation -> annotation.annotationType().equals(JsonPOJOBuilder.class)) | ||
| .hasSize(1).first().asInstanceOf(InstanceOfAssertFactories.type(JsonPOJOBuilder.class)) | ||
| .satisfies(annotation -> { | ||
| assertThat(annotation.withPrefix()).isEqualTo(expectedPrefix); | ||
| }); | ||
| } | ||
|
|
||
| static Stream<Arguments> recordBuilders() { | ||
| return Stream.of(arguments(JacksonAnnotatedRecordBuilder.class, ""), | ||
| arguments(JacksonAnnotatedRecordCustomSetterPrefixBuilder.class, "set")); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(classes = { JacksonAnnotatedRecord.class, JacksonAnnotatedRecordCustomSetterPrefix.class }) | ||
| void deserializingModelInvokesBuilder(Class<? extends JacksonAnnotated> type) throws JsonProcessingException { | ||
| final var json = """ | ||
| { | ||
| "name" : "test" | ||
| } | ||
| """; | ||
|
|
||
| final var model = objectMapper.readValue(json, type); | ||
| assertThat(model.name()).isEqualTo("test"); | ||
| assertThat(model.type()).isEqualTo("dummy"); // default value | ||
| assertThat(model.properties()).isNotNull().isEmpty(); // non-null initialized immutable collection | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid it's not that simple. Recently, Jackson 3 was released with changed package names. Is it possible to check what annotations are presented on the classpath and add appropriate annotation here?