feat: add optional suffix to static builder#134
Open
RichardTree wants to merge 1 commit intoRandgalt:masterfrom
Open
feat: add optional suffix to static builder#134RichardTree wants to merge 1 commit intoRandgalt:masterfrom
RichardTree wants to merge 1 commit intoRandgalt:masterfrom
Conversation
Owner
|
Thanks for the PR - I'll look at this soon. |
codefish1
reviewed
Dec 21, 2022
| */ | ||
| CodeBlock codeBlock = buildCodeBlock(); | ||
| var builder = MethodSpec.methodBuilder(recordClassType.name()) | ||
| var builder = MethodSpec.methodBuilder(recordClassType.name() + metaData.staticBuilderSuffix()) |
Contributor
There was a problem hiding this comment.
Suggested change
| var builder = MethodSpec.methodBuilder(recordClassType.name() + metaData.staticBuilderSuffix()) | |
| var staticBuilderName = Optional.of(metaData.staticBuilderSuffix()).filter(e -> !e.isEmpty()).map(e -> lowerCaseFirstLetter(recordClassType.name())+ e).orElse(recordClassType.name()); | |
| var builder = MethodSpec.methodBuilder(staticBuilderName) |
private String lowerCaseFirstLetter(String value) {
return value.substring(0,1).toLowerCase() + value.substring(1);
}
Might be nicer to lowercase the first letter of the static builder as well so instead of FirstnameOf you have firstnameOf for example
Owner
|
My initial reaction is that RecordBuilder is getting too many options. We've already had some incompatible ones. We may need to re-think the customization scheme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what you think of this, my team are coming from using Immutables heavily and are fond of their FieldName.of() syntax convention for static builders.
I’m assuming my change would enable us to call a static builder like FieldNameBuilder.FieldNameOf().
When statically imported, would read succinctly as FieldNameOf()