Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreshRSS: Read articles switch back to unread #1519

Closed
vincode-io opened this issue Jan 2, 2020 · 3 comments
Closed

FreshRSS: Read articles switch back to unread #1519

vincode-io opened this issue Jan 2, 2020 · 3 comments

Comments

@vincode-io
Copy link
Member

We've been seeing articles that should have been marked as read either not marking as unread or switching back to unread. This is probably how it is happening.

We begin to send our article statuses to the sync service by selecting all available statuses from the sync database.
An article is marked as read and added to the sync database.
We complete sending our statuses.
We request article statuses from the sync service.
The article just marked as read in NNW is unread in the sync service, so we mark it as unread in NNW, putting us in sync with the sync service but out of sync with what we will send to the sync service and what the user is expecting.
Eventually the entry in the sync database gets processed and we go back into a read state for the article or the user manually marks it as read again.
To rectify this we will need to check the sync database for pending entries while processing statuses from the sync service. If we have a pending entry we should discard the sync service status since we know that we have more recent status information than the sync service.

@vincode-io
Copy link
Member Author

I'm removing this from the 5.1 milestone as we don't plan on shipping FreshRSS in 5.1.

@vincode-io vincode-io removed this from the Mac 5.1 Alpha milestone Feb 28, 2020
@Alkarex
Copy link

Alkarex commented Apr 24, 2020

Hello,
Let me know whether I can provide any sparing from FreshRSS side.

Regarding the synchronisation, here is my suggestion of synchronisation strategy, using 7 requests
FreshRSS/FreshRSS#2566 (comment)
For pending local changes, I can also provide a suggestion if you like.

Please ping us when there is something new 😃 FreshRSS/FreshRSS#2916

@vincode-io
Copy link
Member Author

Thanks for checking in @Alkarex. I imagine we will be picking up the FreshRSS integration in the near future and finishing it.

@vincode-io vincode-io added this to the NetNewsWire 6.0 milestone Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants