B

Author: RamyHakam

Tests/Helper/InputFiles/BinaryTreeVerticalOrderTraversalTest.json

@@ -0,0 +1,56 @@
+{
+  "testCase1": {
+    "expectedResult": [[9],[3,15],[20],[7]],
+    "input": {
+      "tree": {
+        "nodes": [
+          {"id": "1", "left": "2", "right": "3", "value": 3},
+          {"id": "2", "left": null, "right": null, "value": 9},
+          {"id": "3", "left": "4", "right": "5", "value": 20},
+          {"id": "4", "left": null, "right": null, "value": 15},
+          {"id": "5", "left": null, "right": null, "value": 7}
+        ],
+        "root": "1"
+      }
+    }
+  },
+  "testCase2": {
+    "expectedResult": [[4],[9],[3,0,1],[8],[7]],
+    "input": {
+      "tree": {
+        "nodes": [
+          {"id": "1", "left": "2", "right": "3", "value": 3},
+          {"id": "2", "left": "4", "right": "5", "value": 9},
+          {"id": "3", "left": "6", "right": "7", "value": 8},
+          {"id": "4", "left": null, "right": null, "value": 4},
+          {"id": "5", "left": null, "right": null, "value": 0},
+          {"id": "6", "left": null, "right": null, "value": 1},
+          {"id": "7", "left": null, "right": null, "value": 7}
+        ],
+        "root": "1"
+      }
+    }
+  },
+  "testCase3": {
+    "expectedResult": [[4],[2,7,8],[1,5,6,10,11,10],[3,9]],
+    "input": {
+      "tree": {
+        "nodes": [
+          {"id": "1", "left": "2", "right": "3", "value": 1},
+          {"id": "2", "left": "4", "right": "5", "value": 2},
+          {"id": "3", "left": "6", "right": null, "value": 3},
+          {"id": "4", "left": null, "right": "7", "value": 4},
+          {"id": "5", "left": "8", "right": null, "value": 5},
+          {"id": "6", "left": null, "right": "9", "value": 6},
+          {"id": "7", "left": null, "right": "10", "value": 7},
+          {"id": "8", "left": null, "right": "11", "value": 8},
+          {"id": "9", "left": "12", "right": null, "value": 9},
+          {"id": "10", "left": null, "right": null, "value": 10},
+          {"id": "11", "left": null, "right": null, "value": 11},
+          {"id": "12", "left": null, "right": null, "value": 10}
+        ],
+        "root": "1"
+      }
+    }
+  }
+}

Tests/Tree/BinaryTreeVerticalOrderTraversalTest.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace Hakam\LeetCodePhp\Tests\Tree;
+
+use Hakam\LeetCodePhp\Tests\Helper\MainTest;
+use Hakam\LeetCodePhp\Tests\Helper\TreeHelperTrait;
+use Hakam\LeetCodePhp\Tree\BinaryTreeVerticalOrderTraversal;
+
+class BinaryTreeVerticalOrderTraversalTest extends MainTest
+{
+    use TreeHelperTrait;
+    /**
+     * @dataProvider provideData
+     */
+    public function testWithDataList($expectedResult, $inputData): void
+    {
+      $tree =  $this->createBinaryTree($inputData);
+      $verticalOrder = new BinaryTreeVerticalOrderTraversal();
+      $result = $verticalOrder->verticalOrder($tree);
+      while (count($expectedResult) !== 0 )
+      {
+          $value = array_diff(array_shift($expectedResult),array_shift($result));
+          self::assertEmpty($value);
+      }
+    }
+}

Tree/BinaryTreeVerticalOrderTraversal.php

@@ -9,41 +9,29 @@ class BinaryTreeVerticalOrderTraversal
      * @return Integer[][]
      */
     private array $order = [];
+    private array $queue = [];
 
-    function verticalOrder($root) {
-
-        $this->verticalNodeOrder($root,0,0);
-        ksort($this->order);
-        return $this->order;
-    }
-
-    public function verticalNodeOrder($node, $index,$row): void
+    public function verticalOrder($root): array
     {
-        if($node === null)
-        {
-            return;
+        if ($root === null) {
+            return [];
         }
-        if(isset($this->order[$index][$row]))
-        {
-            $newRow = $row+1;
-            while(isset($this->order[$index][$newRow]))
-            {
-                ++$newRow;
+
+        $this->queue [] = [$root, 0];
+
+        while (count($this->queue) !== 0) {
+            [$node, $index] = array_shift($this->queue);
+            $this->order[$index][] = $node->val;
+            if ($node->left !== null) {
+                $this->queue [] = [$node->left, $index - 1];
             }
-           $this->order[$index][$newRow] = $node->val;
-        }else {
-            $this->order[$index][$row] = $node->val;
-        }
-        ksort($this->order[$index]);
 
-        if($node->left !== null)
-        {
-            $this->verticalNodeOrder($node->left,$index-1,$row+1);
-        }
+            if ($node->right !== null) {
+                $this->queue [] = [$node->right, $index + 1];
 
-        if($node->right !== null)
-        {
-            $this->verticalNodeOrder($node->right,$index+1,$row+1);
+            }
         }
+        ksort($this->order);
+        return $this->order;
     }
 }