Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS101 reboots with MacBook M2 Pro PD #1887

Open
nuschpl opened this issue Feb 27, 2024 · 8 comments
Open

TS101 reboots with MacBook M2 Pro PD #1887

nuschpl opened this issue Feb 27, 2024 · 8 comments
Assignees

Comments

@nuschpl
Copy link

nuschpl commented Feb 27, 2024

Describe the bug
It cycles through power state 3, then 6 and reboots.

To Reproduce

  1. Connect to MacBook M2 Pro PD
  2. Observe decvice negotiating then rebooting.
  3. Connect with KeyB pressed, get PD Debug state 3, PD Debug state 6.

Expected behavior
Whatever power is provided via USB PD properly negotiate it so the iron will use only supported ones. Ideally when power not sufficient to iron but sufficient for powering up it should display the limitation

Details of your device:

  • Device: TS101
  • Release: [compiled from git head on 2024 Feb 27]
  • Power adapter being used: MacBook M2 Pro Thunderbolt 4 port
@nuschpl
Copy link
Author

nuschpl commented Feb 27, 2024

As a followup - I've attempted to limit artificially maximum power to 15W by modyfing configuration.h . Compiled the firmware and it was working - on 140W capable PD charger it was runing only at 5V max very slowly heating . This is the behaviour I would expect on Macbook but it with same firmwre it still restarts instead - seems like some PD negotiation issue similar to #762 (comment)
I'm eager to debug it further by collecting some logs or compiling custom firmware with some changes , not sure were to start.

@akubak
Copy link

akubak commented Mar 20, 2024

@nuschpl I was able to flash mine by using an old Type-C to USB-A phone cable through a hub connected to my laptop, so that no PD info was passed along to confuse the iron.

@nuschpl
Copy link
Author

nuschpl commented Mar 20, 2024

I'm aware that it should be possible but this issue is not about flashing, it's precisely about proper USB PD support

@dennes544
Copy link

dennes544 commented Jul 20, 2024

Can confirm this. TS101 flashed with latest artifact CI #4051: Commit [545d568], same behaviour. PD Debug state 3 then PD Debug state 6 then reboot. Flashed back to stock 2.10, reboot gone.

Power adapter used: 140W Macbook Pro M3 Max adapter

@dennes544
Copy link

Worked with Baseus GaN2 100W adapter (2 Type-C, 2 Type-A)

@neon12345
Copy link
Contributor

Similar problem with an Ugreen Nexode 140W GaN. There are two usb-c ports, 100W and 140W max. With the 100W port it works and with the 140W port there are constant reboots. Also reboots with my laptop usb-c but is working with a desktop pc.

@dennes544
Copy link

Also strange thing i found: If flash V2.22 from releases page, TS101 works with MBP 140W adapter, BUT if i compile firmware from tag V2.22 via github actions it stops woking again. With keyB pressed on compiled firmware it shows PD state 3 then 1 then reboot.

@Qwertylex
Copy link

Same thing happens here on MacBook Pro M1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants