Skip to content

Commit

Permalink
Auto merge of #128544 - compiler-errors:perf-warn_if_unreachable, r=f…
Browse files Browse the repository at this point in the history
…mease

Check divergence value first before doing span operations in `warn_if_unreachable`

It's more expensive to extract the span's desugaring first rather than check the value of the divergence enum. For some reason I inverted these checks, probably for readability, but as a consequence I regressed perf:

rust-lang/rust#128443 (comment)

r? fmease
  • Loading branch information
bors committed Aug 4, 2024
2 parents 4aa7ef7 + da4fbf6 commit a5eec40
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit a5eec40

Please sign in to comment.