Skip to content

Commit 5548928

Browse files
authored
fs: fix read / readSync positional offset types
This changeset fixes the types in comments to match the implementation. PR-URL: nodejs#52603 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 44f81a1 commit 5548928

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

lib/fs.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,11 @@ function openAsBlob(path, options = kEmptyObject) {
599599
* Reads file from the specified `fd` (file descriptor).
600600
* @param {number} fd
601601
* @param {Buffer | TypedArray | DataView} buffer
602-
* @param {number} offsetOrOptions
602+
* @param {number | {
603+
* offset?: number;
604+
* length?: number;
605+
* position?: number | bigint | null;
606+
* }} [offsetOrOptions]
603607
* @param {number} length
604608
* @param {number | bigint | null} position
605609
* @param {(
@@ -693,7 +697,7 @@ ObjectDefineProperty(read, kCustomPromisifyArgsSymbol,
693697
* specified `fd` (file descriptor).
694698
* @param {number} fd
695699
* @param {Buffer | TypedArray | DataView} buffer
696-
* @param {{
700+
* @param {number | {
697701
* offset?: number;
698702
* length?: number;
699703
* position?: number | bigint | null;

0 commit comments

Comments
 (0)