You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using Link to torrent > Check Files,
and within the torrent there is 1+ file in the directory specified by "Torrent relative data path"
and the value given to "Torrent relative data path" does not end with a directory separator
...an uncaught exception occurs:
System.ArgumentOutOfRangeException: 'startIndex cannot be larger than length of string. Arg_ParamName_Name'
This doesn't affect most Bemani games (I think DDR A/20 is an exception) if the "data" directory is used, as recommended.
The cause AFAICT is that, when the first file in the torrent (within the relative path) is checked, RelativePath is given a separator if it doesn't have one, then its new length is used to try to get a substring from the file's directory path (which doesn't have a separator).
Also, if I understand the code correctly:
Exception on the first file aside, relPath.StartsWith(RelativePath) would return false for any other files in the relative data path.
Again, this doesn't affect most Bemani games, but any such files would not be handled.
The text was updated successfully, but these errors were encountered:
bmn
changed the title
Link to torrent: uncaught exception related to files existing in relative data path
Link to torrent: uncaught exception with files in relative data path
Oct 21, 2022
When using Link to torrent > Check Files,
and within the torrent there is 1+ file in the directory specified by "Torrent relative data path"
and the value given to "Torrent relative data path" does not end with a directory separator
...an uncaught exception occurs:
This doesn't affect most Bemani games (I think DDR A/20 is an exception) if the "data" directory is used, as recommended.
The cause AFAICT is that, when the first file in the torrent (within the relative path) is checked,
RelativePath
is given a separator if it doesn't have one, then its new length is used to try to get a substring from the file's directory path (which doesn't have a separator).Related code:
LincleLINK/LincleLINK/Logic/MainWindowLogic.cs
Lines 535 to 545 in fe02874
Also, if I understand the code correctly:
Exception on the first file aside,
relPath.StartsWith(RelativePath)
would return false for any other files in the relative data path.Again, this doesn't affect most Bemani games, but any such files would not be handled.
The text was updated successfully, but these errors were encountered: