Skip to content

Commit f4bfb2b

Browse files
authored
Register logcat logger (duckduckgo#2628)
Task/Issue URL: https://app.asana.com/0/488551667048375/1203228473135603/f ### Description Forgot to register the `logcat` logger for the VPN process. done ### Steps to test this PR (optional) - [x] install from this branch - [x] filter logcat with `VPN log` - [x] enable AppTP - [x] logs should appear (this test would fail on develop branch)
1 parent 5c4778c commit f4bfb2b

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

app/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,7 @@ dependencies {
273273
implementation "io.reactivex.rxjava2:rxjava:_"
274274
implementation "io.reactivex.rxjava2:rxandroid:_"
275275
implementation JakeWharton.timber
276+
implementation "com.squareup.logcat:logcat:_"
276277

277278
// ThreeTenABP
278279
implementation "com.jakewharton.threetenabp:threetenabp:_"

app/src/main/java/com/duckduckgo/app/global/DuckDuckGoApplication.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ import io.reactivex.plugins.RxJavaPlugins
3434
import java.io.File
3535
import javax.inject.Inject
3636
import kotlinx.coroutines.*
37+
import logcat.AndroidLogcatLogger
38+
import logcat.LogcatLogger
3739
import org.threeten.bp.zone.ZoneRulesProvider
3840
import timber.log.Timber
3941

@@ -93,7 +95,7 @@ open class DuckDuckGoApplication : HasDaggerInjector, MultiProcessApplication()
9395
}
9496

9597
override fun onSecondaryProcessCreate(shortProcessName: String) {
96-
configureLogging()
98+
LogcatLogger.install(AndroidLogcatLogger())
9799
Timber.d("onSecondaryProcessCreate $shortProcessName")
98100
runInSecondaryProcessNamed(VPN_PROCESS_NAME) {
99101
Timber.d("Init for secondary process $shortProcessName")

0 commit comments

Comments
 (0)