Skip to content

Commit eec2359

Browse files
authored
Migrate empty manifest package attribute to namespace DSL (duckduckgo#2133)
Task/Issue URL: https://app.asana.com/0/488551667048375/1202710479869541/f ### Description AGP will not allow setting the package attribute in the source AndroidManifest.xml starting in AGP 8.0. Instead, users must specify a namespace via the namespace DSL. This PR migrates our empty manifest to use `namespace` DSL ### Steps to test this PR - [x] app builds - [x] smoke test for app and AppTP
1 parent c52b40d commit eec2359

File tree

62 files changed

+84
-665
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+84
-665
lines changed

anrs/anrs-api/build.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,7 @@ dependencies {
2626
implementation AndroidX.core.ktx
2727
implementation KotlinX.coroutines.core
2828
}
29+
30+
android {
31+
namespace 'com.duckduckgo.anrs.api'
32+
}

anrs/anrs-api/src/main/AndroidManifest.xml

Lines changed: 0 additions & 21 deletions
This file was deleted.

anrs/anrs-impl/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,5 @@ android {
4747
anvil {
4848
generateDaggerFactories = true // default is false
4949
}
50+
namespace 'com.duckduckgo.app.anr'
5051
}

anrs/anrs-impl/src/main/AndroidManifest.xml

Lines changed: 0 additions & 21 deletions
This file was deleted.

anrs/anrs-store/build.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,3 +50,7 @@ dependencies {
5050
testImplementation project(path: ':common-test')
5151
}
5252

53+
54+
android {
55+
namespace 'com.duckduckgo.app.anrs.store'
56+
}

anrs/anrs-store/src/main/AndroidManifest.xml

Lines changed: 0 additions & 21 deletions
This file was deleted.

app-build-config/app-build-config-api/src/main/AndroidManifest.xml

Lines changed: 0 additions & 21 deletions
This file was deleted.

app-store/build.gradle

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,7 @@ dependencies {
3232
implementation "com.jakewharton.threetenabp:threetenabp:_"
3333

3434
kapt AndroidX.room.compiler
35-
}
35+
}
36+
android {
37+
namespace 'com.duckduckgo.app'
38+
}

app-store/src/main/AndroidManifest.xml

Lines changed: 0 additions & 21 deletions
This file was deleted.

autofill/autofill-api/build.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,7 @@ dependencies {
2929
implementation AndroidX.constraintLayout
3030
}
3131

32+
33+
android {
34+
namespace 'com.duckduckgo.autofill.api'
35+
}

0 commit comments

Comments
 (0)