Skip to content

Commit cdfe0aa

Browse files
authored
Remove redundant pixel (duckduckgo#3825)
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/488551667048375/1205896474029450/f ### Description See attached task description ### Steps to test this PR QA optional
1 parent 06336e4 commit cdfe0aa

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

network-protection/network-protection-impl/src/main/java/com/duckduckgo/networkprotection/impl/pixels/NetworkProtectionPixelNames.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ enum class NetworkProtectionPixelNames(
8888
NETP_WAITLIST_NOTIFICATION_LAUNCHED_DAILY("m_netp_ev_waitlist_notification_launched_d"),
8989
NETP_WAITLIST_NOTIFICATION_LAUNCHED("m_netp_ev_waitlist_notification_launched_c"),
9090
NETP_WAITLIST_BETA_ENABLED_DAILY("m_netp_ev_waitlist_enabled_d"),
91-
NETP_WAITLIST_BETA_ENABLED("m_netp_ev_waitlist_enabled_c"),
9291
NETP_GEOSWITCHING_PAGE_SHOWN("m_netp_imp_geoswitching_c", enqueue = true),
9392
NETP_GEOSWITCHING_SET_NEAREST("m_netp_ev_geoswitching_set_nearest_c", enqueue = true),
9493
NETP_GEOSWITCHING_SET_NEAREST_DAILY("m_netp_ev_geoswitching_set_nearest_d", enqueue = true),

network-protection/network-protection-impl/src/main/java/com/duckduckgo/networkprotection/impl/pixels/NetworkProtectionPixels.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,7 @@ interface NetworkProtectionPixels {
225225
fun waitlistNotificationCancelled()
226226

227227
/**
228-
* This fun will fire two pixels
229-
* daily -> fire only once a day no matter how many times we call this fun
230-
* count -> fire a pixel on every call
228+
* This fun will fire daily -> fire only once a day no matter how many times we call this fun
231229
*
232230
* The pixels fire when the waitlist beta is enabled for th user. This is gated by a remote feature flag
233231
*/
@@ -432,7 +430,6 @@ class RealNetworkProtectionPixel @Inject constructor(
432430

433431
override fun waitlistBetaIsEnabled() {
434432
tryToFireDailyPixel(NETP_WAITLIST_BETA_ENABLED_DAILY)
435-
firePixel(NETP_WAITLIST_BETA_ENABLED)
436433
}
437434

438435
override fun reportGeoswitchingScreenShown() {

0 commit comments

Comments
 (0)