-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bsp][nrf5x]added the cherryusb adapter for nrf52840 #9939
Merged
supperthomas
merged 1 commit into
RT-Thread:master
from
hydevcode:nrf52840_cherryusb_adapt
Jan 24, 2025
Merged
[bsp][nrf5x]added the cherryusb adapter for nrf52840 #9939
supperthomas
merged 1 commit into
RT-Thread:master
from
hydevcode:nrf52840_cherryusb_adapt
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
BSP
Component
component: drivers/usb
component: drivers
labels
Jan 21, 2025
supperthomas
requested changes
Jan 21, 2025
hydevcode
force-pushed
the
nrf52840_cherryusb_adapt
branch
from
January 21, 2025 08:12
5fb3096
to
f9848bf
Compare
supperthomas
approved these changes
Jan 21, 2025
supperthomas
requested changes
Jan 21, 2025
bsp/nrf5x/nrf52840/board/port/cherryusb/cherryusb_usbd_compostite_init.c
Outdated
Show resolved
Hide resolved
hydevcode
force-pushed
the
nrf52840_cherryusb_adapt
branch
from
January 22, 2025 07:49
07c2551
to
cf199f5
Compare
@sakumisu 大佬,帮忙review一下。 |
port 名称改下把,不要叫 composite xxx,就 cherryusb.c 就好 |
hydevcode
force-pushed
the
nrf52840_cherryusb_adapt
branch
from
January 24, 2025 11:47
e182a22
to
1f1f230
Compare
ok,改好了 |
+1 |
supperthomas
approved these changes
Jan 24, 2025
1078249029
pushed a commit
to 1078249029/rt-thread
that referenced
this pull request
Jan 25, 2025
1078249029
pushed a commit
to 1078249029/rt-thread
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
添加nrf52840的cherryusb适配
你的解决方案是什么 (what is your solution)
将赵工@Ghost-Girls 提供的已移植好的cherryusb文件适配到RT-Thread
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up