Skip to content

[tools]fix scons --dist , menuconfig will error #8069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

zhkag
Copy link
Member

@zhkag zhkag commented Sep 22, 2023

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#7918
#8066

你的解决方案是什么 (what is your solution)

修改 dist 脚本 添加缺失的文件

在什么测试环境下测试通过 (what is the test environment)

qemu aarch64
qemu a9

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@zhkag zhkag added the v5.0.2 label Sep 22, 2023
@zhkag
Copy link
Member Author

zhkag commented Sep 22, 2023

dist 时添加了缺失的 kconfig 文件 不确定这种方法是否合适

另外的两种方法是

  1. 在 kconfig 中去掉相关定义
  2. libcpu 目录下的文件全部复制过去

@supperthomas
Copy link
Member

#7922

把这个action修改加上看看

@zhkag zhkag requested a review from supperthomas as a code owner September 22, 2023 05:05
@supperthomas
Copy link
Member

是不是也可以把这个kconfig这一段给删了?其他平台的话

@zhkag
Copy link
Member Author

zhkag commented Sep 22, 2023

是不是也可以把这个kconfig这一段给删了?其他平台的话

可以,但是那样的话容易出错,然后就没有那样写,这样写的话更改还小一点

@Guozhanxin
Copy link
Member

320f1f28e8c343fab882d0f57523f23
这个文件一共也没几行,还不如直接把内容加过来,把文件删了

@supperthomas supperthomas merged commit b243312 into RT-Thread:master Sep 26, 2023
@archeno
Copy link

archeno commented Sep 27, 2023

怎么解决的?

@supperthomas
Copy link
Member

supperthomas commented Sep 27, 2023

怎么解决的?

可以看下差异修改的地方。
https://github.com/RT-Thread/rt-thread/pull/8069/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants