Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

将rt_mutex_init()由RT_IPC_FLAG_FIFO改为RT_IPC_FLAG_PRIO #4662

Closed
wants to merge 5 commits into from
Closed

将rt_mutex_init()由RT_IPC_FLAG_FIFO改为RT_IPC_FLAG_PRIO #4662

wants to merge 5 commits into from

Conversation

mysterywolf
Copy link
Member

@mysterywolf mysterywolf commented May 7, 2021

Signed-off-by: Meco Man 920369182@qq.com

拉取/合并请求描述:(PR description)

[
边缘化RT_IPC_FLAG_FIFO
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并符合RT-Thread代码规范 This PR complies with RT-Thread code specification

Signed-off-by: Meco Man <920369182@qq.com>
@mysterywolf mysterywolf requested review from enkiller and KyleChenjh and removed request for enkiller May 7, 2021 02:43
@mysterywolf
Copy link
Member Author

请无视format错误

@mysterywolf mysterywolf requested a review from Guozhanxin May 7, 2021 11:48
@Guozhanxin Guozhanxin added the +1 Agree +1 label May 8, 2021
@mysterywolf mysterywolf removed the request for review from KyleChenjh May 8, 2021 07:18
@KyleChenjh KyleChenjh added the +2 Agree +2 label May 10, 2021
@mysterywolf mysterywolf added the reviewed PR has been reviewed. label May 10, 2021
@BernardXiong
Copy link
Member

Please fix this issue: 'Check File Format and License / Scan code format and license (pull_request) '.

@mysterywolf
Copy link
Member Author

mysterywolf commented May 13, 2021

这个修复不了,这个不是我的问题引起的,我只是改了一个flag,这个是被改文件其他位置引起的。该CI会扫描整个文件,只要文件一处不符合规定就会报错。CI只是提供一个参考,如果修改无误就可以人工合并了。
此pr只修复特定问题,后续会提交format codes的代码,否则一个pr里夹杂了一堆format codes,不清晰。

@mysterywolf mysterywolf deleted the mutex branch May 18, 2021 11:53
@mysterywolf mysterywolf restored the mutex branch July 2, 2021 10:40
@mysterywolf mysterywolf reopened this Jul 2, 2021
@mysterywolf
Copy link
Member Author

#4704

@BernardXiong
Copy link
Member

Please check them one by one and carefully. Please not modify BSP.

@mysterywolf mysterywolf deleted the mutex branch July 4, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed PR has been reviewed. +1 Agree +1 +2 Agree +2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants