Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

为stm32的PWM驱动添加对STM32H7的支持、添加互补PWM功能的支持,补全pwm_get命令等 #4250

Merged
merged 5 commits into from
Jan 21, 2021

Conversation

Hotakus
Copy link
Contributor

@Hotakus Hotakus commented Jan 19, 2021

拉取/合并请求描述:(PR description)

[在STM32H7系列使用STM32的PWM驱动时,发现H7宏定义缺失,添加后解决、发现不支持PWM的互补输出,原因为使能PWM输出的底层函数未有添加相应PWM的互补输出函数,导致互补PWM输出没有反应,添加并做兼容性处理后解决此问题,并完善缺失的pwm_get函数。修改在ART-PI和其他核心板上测试成功]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2021

CLA assistant check
All committers have signed the CLA.

@BernardXiong BernardXiong added the BSP: STM32 BSP related with ST/STM32 label Jan 19, 2021
@Guozhanxin Guozhanxin requested a review from whj4674672 January 19, 2021 12:22
components/drivers/include/drivers/rt_drv_pwm.h Outdated Show resolved Hide resolved
bsp/stm32/libraries/HAL_Drivers/drv_pwm.c Outdated Show resolved Hide resolved
bsp/stm32/libraries/HAL_Drivers/drv_pwm.c Outdated Show resolved Hide resolved
@whj4674672 whj4674672 added the +1 Agree +1 label Jan 20, 2021
@BernardXiong
Copy link
Member

Please double check with '+2' because the component code has been modified. @Guozhanxin

@Guozhanxin Guozhanxin added +2 Agree +2 and removed +1 Agree +1 labels Jan 21, 2021
@BernardXiong BernardXiong merged commit 7ed63ef into RT-Thread:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: STM32 BSP related with ST/STM32 +2 Agree +2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants