Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoclosed words not reverted back via u key #24

Closed
aliaksandrb opened this issue Apr 17, 2023 · 0 comments · Fixed by #25
Closed

Autoclosed words not reverted back via u key #24

aliaksandrb opened this issue Apr 17, 2023 · 0 comments · Fixed by #25

Comments

@aliaksandrb
Copy link

aliaksandrb commented Apr 17, 2023

Within existing nesting group the plugin leaves auto-closed end's when history reverted back via u key.

  1. open an existing file, ex:
class A
  def b
   p 1
  end

  def c
    p 2
  end
end
  1. Add a nested group
class A
  module B
    def x
       |
    end  # autoclosed 👍 
  end # autoclosed 👍 
  def b
   p 1
  end

  def c
    p 2
  end
end
  1. Revert it back via u key multiple times. It stops in this state:
class A
  end # left 👎 
  def b
   p 1
  end

  def c
    p 2
  end
end

Please notice the end left behind. I would expect it reverts back into initial state instead.

Here is short video example: https://user-images.githubusercontent.com/526022/232875662-89ecbd07-6fe1-4c65-8b98-cefd6bafd3c1.mov

@johnc219 johnc219 mentioned this issue Apr 30, 2023
@RRethy RRethy closed this as completed in 944b0d8 Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant