[TESTERS NEEDED] Improved contextual menu

[digant73]

Just some improvements on the current contextual menu:

• added Remove Savestate item on Remove sub-menu
• created Open Folder sub menu: it collects all the open folder items previously present on the main contextual menu plus the addition of resource folders useful to quickly access files for drag&drop on the RPCS3's github project (e.g. for bug report), such as:
  • savestate
  • captures
  • recording
  • screenshots
• created Manage Game sub menu: it collects a series of items related to game such as hide, shortcuts creation, game renaming and removal previously present on the main contextual menu
• improved Remove Disc Game / Remove xxx dialog box (item present on the new Manage Game sub menu) to allow a fast, clean and more safe removal of no more needed contents that can take several GB as zombies on disk without the need to manually access RPCS3's folders and/or configuration files and potentially removing wrong files or folders by mistake:

  • the dialog box allows to control the full removal of game data if the contextual menu is related to a game data type (e.g. PS3 Game Data, HDD Game etc.)

    NOTES:

    1. lock files under dev_hdd0/game/$locks folder are always removed allowing a re-installation of the content from scratch (e.g. installation of game demo included in a content etc.)
    2. removal of multiple Game Data folders is supported

  • the dialog box allows to control the removal of both the game data (as on bullet above) and the Disc Game (removal of the title from games.yml file) if the contextual menu is related to a Disc Game type

    NOTES:

    1. unlike the previous bullet, game data can be managed without the need to enable Game Data item under View->Game Category menu
    2. if the Disc Game is located under the auto-detection games folder then the title is not allowed to be selected for removal (the title will reappear on the list on next game list's page refresh or RPCS3 restart)

  • the dialog box allows to select optional contents for removal such as:

    • caches and custom configs
    • icons and shortcuts (currently, removal of shortcuts on desktop and Start menu are not supported)
    • savestate file
    • capture files
    • recording files
    • screenshots files

  • the dialog box do not allow the removal of game saves, trophies files present under dev_hdd0/home/<xxxxxxxx> folder:

    • they usually take few MB and normally users prefer to maintain them
    • they are already fully managed by RPCS3 by specific windows that you can open from the RPCS3's Manage menu

resolve #15994

[elad335]

Can removal of savestates be added to the menu as well? or it already has?

[Megamouse]

It only allows to remove savestates when you remove the game.

[Megamouse]

Please remove all unnecessary changes. There's no need to move the entire code around if all you do is change the location in some menu

[digant73]

Please remove all unnecessary changes. There's no need to move the entire code around if all you do is change the location in some menu

I would do that if the code was still readable but code for Custom Icons' menu was in between the moved menus making the code fragmented. The main part moved is for the new Open Folder menu (not current code)

[Megamouse]

First of all you're not even only moving the code, you're changing it's formatting to something worse.
Second, I don't see how the code is fragmented if you only move the addAction somewhere below.

[Megamouse]

Here we go again...

[digant73]

First of all you're not even only moving the code, you're changing it's formatting to something worse. Second, I don't see how the code is fragmented if you only move the addAction somewhere below.

Good catch. The indentation on connect blocks on the moved and mostly mew code was applied by VS (I have to disable that stupid aid). Now it should be ok

[Megamouse]

First of all you're not even only moving the code, you're changing it's formatting to something worse. Second, I don't see how the code is fragmented if you only move the addAction somewhere below.

Good catch. The indentation on connect blocks on the moved and mostly mew code was applied by VS (I have to disable that stupid aid). Now it should be ok

This isn't really anyone's fault. It's a bug in clangformat. We just usually fix the indentation manually before we commit.

[digant73]

First of all you're not even only moving the code, you're changing it's formatting to something worse. Second, I don't see how the code is fragmented if you only move the addAction somewhere below.

Good catch. The indentation on connect blocks on the moved and mostly mew code was applied by VS (I have to disable that stupid aid). Now it should be ok

This isn't really anyone's fault. It's a bug in clangformat. We just usually fix the indentation manually before we commit.

That is also what I'm doing all the time (manually correct the indentation when it is changed and it differs from the code style used in this project)

[digant73]

is there something wrong for the merge?

[Megamouse]

No one has tested it yet

[digant73]

No one has tested it yet

It is fully tested and working from my side. Anyway, I will change the title of the PR asking for testing

[ItsLaguna]

Would be possible to move the remove disc/hdd game/PS3 game data option to Remove instead of having it under Manage Game? It's counter-intuitive.